Fix for issue 339

Fix for issue 339:
- Move GetHiddenProperties functionality from object.cc to handle.cc to
  be more robust in the presence of GC in the middle of the function.


Committed: http://code.google.com/p/v8/source/detail?r=1924

[Kasper Lund, 2009-05-12 05:31:39]

LGTM. Nice test case.

http://codereview.chromium.org/113222/diff/1/3
File src/handles.cc (right):

http://codereview.chromium.org/113222/diff/1/3#newcode304
Line 304: return Handle<Object>(obj->GetProperty(*key));
I guess GetProperty(*key) never returns a failure, so never need to retry. I
guess you could use GetProperty(obj, key) instead to avoid forcing me to think
about it.

[iposva, 2009-05-12 18:15:05]

http://codereview.chromium.org/113222/diff/1/3
File src/handles.cc (right):

http://codereview.chromium.org/113222/diff/1/3#newcode304
Line 304: return Handle<Object>(obj->GetProperty(*key));
On 2009/05/12 05:31:39, Kasper Lund wrote:
> I guess GetProperty(*key) never returns a failure, so never need to retry. I
> guess you could use GetProperty(obj, key) instead to avoid forcing me to think
> about it.

Done.