Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1132203005: Fix the behavior of 'super.foo' assignment when receiver is not an object. (Closed)

Created:
5 years, 7 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix the behavior of 'super.foo' assignment when receiver is not an object. R=arv@chromium.org,verwaest@chromium.org BUG=v8:4097 LOG=N Committed: https://crrev.com/30b771a662d7056190205de7667d2b4a4897af2e Cr-Commit-Position: refs/heads/master@{#28377}

Patch Set 1 #

Total comments: 4

Patch Set 2 : CR feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/es6/regress/regress-4097.js View 1 1 chunk +37 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (3 generated)
Dmitry Lomov (no reviews)
PTAL
5 years, 7 months ago (2015-05-12 16:26:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132203005/1
5 years, 7 months ago (2015-05-12 16:27:01 UTC) #3
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/1132203005/diff/1/test/mjsunit/es6/regress/regress-4097.js File test/mjsunit/es6/regress/regress-4097.js (right): https://codereview.chromium.org/1132203005/diff/1/test/mjsunit/es6/regress/regress-4097.js#newcode6 test/mjsunit/es6/regress/regress-4097.js:6: "use strict"; wrong indentation... use 2 spaces https://codereview.chromium.org/1132203005/diff/1/test/mjsunit/es6/regress/regress-4097.js#newcode9 ...
5 years, 7 months ago (2015-05-12 16:44:20 UTC) #4
Dmitry Lomov (no reviews)
Comments addressed, landing https://codereview.chromium.org/1132203005/diff/1/test/mjsunit/es6/regress/regress-4097.js File test/mjsunit/es6/regress/regress-4097.js (right): https://codereview.chromium.org/1132203005/diff/1/test/mjsunit/es6/regress/regress-4097.js#newcode6 test/mjsunit/es6/regress/regress-4097.js:6: "use strict"; On 2015/05/12 16:44:20, arv ...
5 years, 7 months ago (2015-05-12 16:50:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132203005/20001
5 years, 7 months ago (2015-05-12 16:50:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 17:13:17 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/30b771a662d7056190205de7667d2b4a4897af2e Cr-Commit-Position: refs/heads/master@{#28377}
5 years, 7 months ago (2015-05-12 17:13:34 UTC) #10
arv (Not doing code reviews)
https://codereview.chromium.org/1132203005/diff/20001/test/mjsunit/es6/regress/regress-4097.js File test/mjsunit/es6/regress/regress-4097.js (right): https://codereview.chromium.org/1132203005/diff/20001/test/mjsunit/es6/regress/regress-4097.js#newcode6 test/mjsunit/es6/regress/regress-4097.js:6: "use strict"; indentation is still borked. 1 space here ...
5 years, 7 months ago (2015-05-12 17:16:34 UTC) #11
Dmitry Lomov (no reviews)
5 years, 7 months ago (2015-05-12 17:18:58 UTC) #12
Message was sent while issue was closed. 
On 2015/05/12 17:16:34, arv wrote:
>
https://codereview.chromium.org/1132203005/diff/20001/test/mjsunit/es6/regres...
> File test/mjsunit/es6/regress/regress-4097.js (right):
> 
>
https://codereview.chromium.org/1132203005/diff/20001/test/mjsunit/es6/regres...
> test/mjsunit/es6/regress/regress-4097.js:6: "use strict";
> indentation is still borked. 1 space here and tabs (?) online 9 and 27.
> 
> Feel free to TBR a change.

Ooops. Will do.

Powered by Google App Engine
This is Rietveld 408576698