Don't crash in StatisticsRecorder if VLOG level changes.

Don't crash in StatisticsRecorder if VLOG level changes.

This happens, for instance, when specifying "--v" command-line argument
to browser_tests (which is suspicious itself, but nevertheless
DCHECK'ing here is not the best behavior).

BUG=487283
Committed: https://crrev.com/61a21ec4569ab4b134cf2ed2b87bbf6736a65481
Cr-Commit-Position: refs/heads/master@{#329670}

[emaxx, 2015-05-12 16:37:39]

emaxx@chromium.org changed reviewers:
+ isherman@chromium.org

[emaxx, 2015-05-12 16:37:39]

Hi Ilya, please take a look at this tiny review about a logging issue in the
statistics recorder.

[Ilya Sherman, 2015-05-12 20:18:34]

https://codereview.chromium.org/1132203004/diff/1/base/metrics/statistics_rec...
File base/metrics/statistics_recorder.cc (right):

https://codereview.chromium.org/1132203004/diff/1/base/metrics/statistics_rec...
base/metrics/statistics_recorder.cc:290: return;
I think we can just remove this check.  The function is only registered as a
callback when vlog is on at construction time, so in normal operation there's no
way to hit this path.

Alternately, you could remove the check on line 283.

[emaxx, 2015-05-13 12:04:24]

Removed the VLOG check.

[Ilya Sherman, 2015-05-13 17:35:33]

LGTM, thanks.

[Ilya Sherman, 2015-05-13 17:35:39]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2015-05-13 17:37:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132203004/20001

[commit-bot: I haz the power, 2015-05-13 17:43:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-13 17:45:35]

Patchset 2 (id:??) landed as
https://crrev.com/61a21ec4569ab4b134cf2ed2b87bbf6736a65481
Cr-Commit-Position: refs/heads/master@{#329670}