Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1132173003: Update folder hierarchy to match java package name. (Closed)

Created:
5 years, 7 months ago by newt (away)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update folder hierarchy to match java package name. Files in chrome/android/sync_shell/javatests use the org.chromium.chrome.browser.sync Java package, but were located under src/chromium/chrome/browser/sync. This fixes the problem by adding an "org" directory. R=nyquist@chromium.org, pvalenzuela@chromium.org TBR=manisicalco@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4b37fced1d594ce46aad0a2faaa88f2eded2e192

Patch Set 1 #

Patch Set 2 : updated GN/gyp #

Patch Set 3 : rebase #

Messages

Total messages: 23 (9 generated)
newt (away)
PTAL
5 years, 7 months ago (2015-05-12 00:13:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132173003/1
5 years, 7 months ago (2015-05-12 00:15:18 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62851)
5 years, 7 months ago (2015-05-12 00:26:05 UTC) #6
nyquist
update GYP/GN? chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java is JNI thing
5 years, 7 months ago (2015-05-12 00:34:52 UTC) #7
newt (away)
On 2015/05/12 00:34:52, nyquist wrote: > update GYP/GN? > chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java > is JNI thing Done. ...
5 years, 7 months ago (2015-05-12 00:43:01 UTC) #8
newt (away)
+pvalenzuela: for trivial GYP/GN changes in src/sync
5 years, 7 months ago (2015-05-12 00:43:59 UTC) #10
pval...(no longer on Chromium)
Thanks for making this change. LGTM for sync_tests.gypi, but it doesn't look like I have ...
5 years, 7 months ago (2015-05-12 17:52:53 UTC) #12
newt (away)
TBR'ing manisicalco since it's a trivial build file change
5 years, 7 months ago (2015-05-12 21:57:51 UTC) #13
newt (away)
nyquist: ping
5 years, 7 months ago (2015-05-12 21:58:42 UTC) #16
nyquist
lgtm
5 years, 7 months ago (2015-05-12 23:49:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132173003/20001
5 years, 7 months ago (2015-05-13 00:04:01 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63184)
5 years, 7 months ago (2015-05-13 00:12:54 UTC) #21
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4b37fced1d594ce46aad0a2faaa88f2eded2e192 Cr-Commit-Position: refs/heads/master@{#329547}
5 years, 7 months ago (2015-05-13 00:53:15 UTC) #22
newt (away)
5 years, 7 months ago (2015-05-13 00:53:25 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4b37fced1d594ce46aad0a2faaa88f2eded2e192 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698