Implement the advertising functions for the BLE API.

extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_BLUETOOTH_LOW_ENERGY_BLUETOOTH_LOW_ENERGY_API_H_
 #define EXTENSIONS_BROWSER_API_BLUETOOTH_LOW_ENERGY_BLUETOOTH_LOW_ENERGY_API_H_
 
 #include "base/memory/scoped_ptr.h"
+#include "device/bluetooth/bluetooth_advertisement.h"
+#include "extensions/browser/api/api_resource_manager.h"
 #include "extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h"
 #include "extensions/browser/browser_context_keyed_api_factory.h"
 #include "extensions/browser/extension_function.h"
 #include "extensions/browser/extension_function_histogram_value.h"
 
 namespace extensions {
 
+class BluetoothApiAdvertisement;
 class BluetoothLowEnergyEventRouter;
 
 // The profile-keyed service that manages the bluetoothLowEnergy extension API.
 class BluetoothLowEnergyAPI : public BrowserContextKeyedAPI {
  public:
   static BrowserContextKeyedAPIFactory<BluetoothLowEnergyAPI>*
       GetFactoryInstance();
 
   // Convenience method to get the BluetoothLowEnergy API for a browser context.
   static BluetoothLowEnergyAPI* Get(content::BrowserContext* context);
@@ skipping 296 matching lines @@
  private:
   // Success and error callbacks, called by
   // BluetoothLowEnergyEventRouter::WriteDescriptorValue.
   void SuccessCallback();
   void ErrorCallback(BluetoothLowEnergyEventRouter::Status status);
 
   // The instance ID of the requested descriptor.
   std::string instance_id_;
 };
 
+class BluetoothLowEnergyAdvertisementFunction
+    : public BluetoothLowEnergyExtensionFunction {
+ public:
+  BluetoothLowEnergyAdvertisementFunction();
+
+ protected:
+  ~BluetoothLowEnergyAdvertisementFunction() override;
+
+  // Takes ownership.
+  int AddAdvertisement(BluetoothApiAdvertisement* advertisement);
+  BluetoothApiAdvertisement* GetAdvertisement(int advertisement_id);
+  void RemoveAdvertisement(int advertisement_id);
+
+  // ExtensionFunction override.
+  bool RunAsync() override;
+
+ private:
+  void Initialize();
+
+  ApiResourceManager<BluetoothApiAdvertisement>* advertisements_manager_;
+
+  DISALLOW_COPY_AND_ASSIGN(BluetoothLowEnergyAdvertisementFunction);
+};
+
 class BluetoothLowEnergyRegisterAdvertisementFunction
-    : public BluetoothLowEnergyExtensionFunction {

[armansito, 2015/05/08 22:46:13]

I'm trying to understand why this base class is necessary. I don't see you
initialize advertisements_manager_ anywhere and I don't see the AddAdvertisement
and RemoveAdvertisement functions get called anywhere either. Wouldn't it be
better to do this the way BluetoothLowEnergyConnectFunction is implemented?
Basically the BluetoothLowEnergyEventRouter class deals with checking whether an
API resource exists or not and creates the correct entry as needed. I don't see
where you're doing that management in this CL, though maybe I missed something?

[rkc, 2015/05/11 21:59:35]

Explained offline.

+    : public BluetoothLowEnergyAdvertisementFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("bluetoothLowEnergy.registerAdvertisement",
                              BLUETOOTHLOWENERGY_REGISTERADVERTISEMENT);
 
  protected:
   ~BluetoothLowEnergyRegisterAdvertisementFunction() override {}
 
   // BluetoothLowEnergyExtensionFunction override.
   bool DoWork() override;
 
  private:
-  // Success and error callbacks, called by
-  // BluetoothLowEnergyEventRouter::WriteDescriptorValue.
-  void SuccessCallback();
-  void ErrorCallback(BluetoothLowEnergyEventRouter::Status status);
+  void SuccessCallback(scoped_refptr<device::BluetoothAdvertisement>);
+  void ErrorCallback(device::BluetoothAdvertisement::ErrorCode status);
 
   // The instance ID of the requested descriptor.
   std::string instance_id_;
 };
 
 class BluetoothLowEnergyUnregisterAdvertisementFunction
-    : public BluetoothLowEnergyExtensionFunction {
+    : public BluetoothLowEnergyAdvertisementFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("bluetoothLowEnergy.unregisterAdvertisement",
                              BLUETOOTHLOWENERGY_UNREGISTERADVERTISEMENT);
 
  protected:
   ~BluetoothLowEnergyUnregisterAdvertisementFunction() override {}
 
   // BluetoothLowEnergyExtensionFunction override.
   bool DoWork() override;
 
  private:
-  // Success and error callbacks, called by
-  // BluetoothLowEnergyEventRouter::WriteDescriptorValue.
-  void SuccessCallback();
-  void ErrorCallback(BluetoothLowEnergyEventRouter::Status status);
+  void SuccessCallback(int advertisement_id);
+  void ErrorCallback(int advertisement_id,
+                     device::BluetoothAdvertisement::ErrorCode status);
 
   // The instance ID of the requested descriptor.
   std::string instance_id_;
 };
 
 }  // namespace core_api
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_BLUETOOTH_LOW_ENERGY_BLUETOOTH_LOW_ENERGY_API_H_