Issue 1132163002: Fix compilation under chromium checkouts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1132163002: Fix compilation under chromium checkouts. (Closed)

Created:
5 years, 7 months ago by Tom Sepez

Modified:
5 years, 7 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix compilation under chromium checkouts. This is a fix to hide pdfium's safe_conversions.h from the higher-level callers. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6661fd4c26106cd530d187b36f29be7e5c98b70f

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	core/include/fxcrt/fx_system.h	View	1 2	1 chunk	+0 lines, -8 lines	0 comments	Download

Total messages: 5 (1 generated)

Lei Zhang

lgtm Are we still going to try for a checked_cast later?

5 years, 7 months ago (2015-05-08 19:31:16 UTC) #3

Tom Sepez

On 2015/05/08 19:31:16, Lei Zhang wrote: > lgtm > > Are we still going to ...

5 years, 7 months ago (2015-05-08 20:20:50 UTC) #4

Tom Sepez

5 years, 7 months ago (2015-05-08 20:21:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
6661fd4c26106cd530d187b36f29be7e5c98b70f (presubmit successful).