Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1905)

Issue 1132153003: PPC: [strong] Check arity of functions (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [strong] Check arity of functions Port 3226e980200035f37c86fef4b11fb307e17764a2 Original commit message: In strong mode it is an error to call a function with too few arguments. This is enforced inside the ArgumentsAdaptorTrampoline. This does not yet handle rest parameters R=arv@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/08d83d651f558bb134d568e317b04081d8f09c60 Cr-Commit-Position: refs/heads/master@{#28348}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/ppc/builtins-ppc.cc View 1 chunk +21 lines, -0 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-11 18:40:35 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 7 months ago (2015-05-11 18:42:50 UTC) #2
dstence
lgtm
5 years, 7 months ago (2015-05-11 18:43:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132153003/1
5 years, 7 months ago (2015-05-11 18:44:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 19:08:56 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/08d83d651f558bb134d568e317b04081d8f09c60 Cr-Commit-Position: refs/heads/master@{#28348}
5 years, 7 months ago (2015-05-11 19:09:08 UTC) #7
paul.l...
Late, drive-by comment: https://codereview.chromium.org/1132153003/diff/1/src/ppc/builtins-ppc.cc File src/ppc/builtins-ppc.cc (right): https://codereview.chromium.org/1132153003/diff/1/src/ppc/builtins-ppc.cc#newcode1772 src/ppc/builtins-ppc.cc:1772: #if V8_TARGET_ARCH_PPC64 Can you avoid ifdef ...
5 years, 7 months ago (2015-05-12 01:49:49 UTC) #9
MTBrandyberry
5 years, 7 months ago (2015-05-12 13:49:05 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1132153003/diff/1/src/ppc/builtins-ppc.cc
File src/ppc/builtins-ppc.cc (right):

https://codereview.chromium.org/1132153003/diff/1/src/ppc/builtins-ppc.cc#new...
src/ppc/builtins-ppc.cc:1772: #if V8_TARGET_ARCH_PPC64
On 2015/05/12 01:49:49, paul.l... wrote:
> Can you avoid ifdef here by using SharedFunctionInfo::kStrongModeBitWithinByte
> as x64 & ia32 (and now mips64) do? Implies also changing load to lbz(r7,
> FieldMemOperand(r7, SharedFunctionInfo::kStrongModeByteOffset));

Makes sense.  I'll look at doing this in a future CL.

Powered by Google App Engine
This is Rietveld 408576698