[Chromoting] Run jscompile over JS for HTML files (GN-only)

[Chromoting] Run jscompile over JS for HTML files (GN-only)

BUG=

Committed: https://crrev.com/5a9293701559db704ba9950f29b38b03bbe080d4
Cr-Commit-Position: refs/heads/master@{#330405}

[garykac, 2015-05-18 17:08:53]

garykac@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[garykac, 2015-05-18 17:08:54]

https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/build_templ...
File remoting/webapp/build_template.gni (right):

https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/build_templ...
remoting/webapp/build_template.gni:115: html_template_include_files = []
Add '_include' to make it easier to distinguish.

https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/files.gni
File remoting/webapp/files.gni (left):

https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/files.gni#o...
remoting/webapp/files.gni:375: "base/js/client_session.js",
No longer needed thanks for refactoring.
Removing it to remove jscompile errors.

[kelvinp, 2015-05-18 17:30:37]

kelvinp@chromium.org changed reviewers:
+ kelvinp@chromium.org

[kelvinp, 2015-05-18 17:30:38]

lgtm

https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/files.gni
File remoting/webapp/files.gni (left):

https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/files.gni#o...
remoting/webapp/files.gni:375: "base/js/client_session.js",
On 2015/05/18 17:08:54, garykac wrote:
> No longer needed thanks for refactoring.
> Removing it to remove jscompile errors.

Yay :)

[garykac, 2015-05-18 17:45:04]

The CQ bit was checked by garykac@chromium.org

[commit-bot: I haz the power, 2015-05-18 17:45:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132133008/1

[commit-bot: I haz the power, 2015-05-18 20:41:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-18 22:42:26]

Patchset 1 (id:??) landed as
https://crrev.com/5a9293701559db704ba9950f29b38b03bbe080d4
Cr-Commit-Position: refs/heads/master@{#330405}

[Nico, 2015-06-03 22:05:04]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-06-03 22:05:04]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-06-03 22:05:05]

If I build all targets I get

[33/322] ACTION
//remoting/webapp:ar_sample_app_loading_window_html_jscompile(//build/toolchain/win:clang_x64)
FAILED: C:/python_27_amd64/files/python.exe gyp-win-tool action-wrapper
environment.x86 __remoting_webapp_ar_sample_app_loading_window_html_
jscompile___build_toolchain_win_clang_x64__rule.rsp
(ERROR) 'java' is not recognized as an internal or external command,
operable program or batch file.


Could you make this opt-in? All targets should be buildable without java.

(+dbeam who probably figured this out in other places that use the closure
compiler)

[Nico, 2015-06-03 22:05:08]

If I build all targets I get

[33/322] ACTION
//remoting/webapp:ar_sample_app_loading_window_html_jscompile(//build/toolchain/win:clang_x64)
FAILED: C:/python_27_amd64/files/python.exe gyp-win-tool action-wrapper
environment.x86 __remoting_webapp_ar_sample_app_loading_window_html_
jscompile___build_toolchain_win_clang_x64__rule.rsp
(ERROR) 'java' is not recognized as an internal or external command,
operable program or batch file.


Could you make this opt-in? All targets should be buildable without java.

(+dbeam who probably figured this out in other places that use the closure
compiler)

[Dan Beam, 2015-06-03 22:09:55]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-06-03 22:09:56]

maybe this?

https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/build_templ...
File remoting/webapp/build_template.gni (right):

https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/build_templ...
remoting/webapp/build_template.gni:51: target_jscompile_stamp =
"$target_gen_dir/${target_jscompile}.stamp"
if (run_jscompile) {

https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/build_templ...
remoting/webapp/build_template.gni:67: }
}

[garykac, 2015-06-03 22:56:05]

On 2015/06/03 22:09:56, Dan Beam wrote:
> maybe this?
> 
>
https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/build_templ...
> File remoting/webapp/build_template.gni (right):
> 
>
https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/build_templ...
> remoting/webapp/build_template.gni:51: target_jscompile_stamp =
> "$target_gen_dir/${target_jscompile}.stamp"
> if (run_jscompile) {
> 
>
https://codereview.chromium.org/1132133008/diff/1/remoting/webapp/build_templ...
> remoting/webapp/build_template.gni:67: }
> }

See crrev.com/1163843009