Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp - Issue 113213002: Rename toWebCoreString*() utility methods to toCoreString*()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

Issue 113213002: Rename toWebCoreString*() utility methods to toCoreString*() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Keep "to" prefix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp ('k') | Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

diff --git a/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp b/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

index 7d83d856fc37bb3c41361a5217e89fd87a3336ef..cb545e6e3a3afe6fe68222b6fe08957684714df4 100644

--- a/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

+++ b/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

@@ -365,7 +365,7 @@ void V8InjectedScriptHost::setFunctionVariableValueMethodCustom(const v8::Functi

{

v8::Handle<v8::Value> functionValue = info[0];

int scopeIndex = info[1]->Int32Value();

- String variableName = toWebCoreStringWithUndefinedOrNullCheck(info[2]);

+ String variableName = toCoreStringWithUndefinedOrNullCheck(info[2]);

v8::Handle<v8::Value> newValue = info[3];

InjectedScriptHost* host = V8InjectedScriptHost::toNative(info.Holder());

@@ -430,7 +430,7 @@ void V8InjectedScriptHost::monitorFunctionMethodCustom(const v8::FunctionCallbac

}

InjectedScriptHost* host = V8InjectedScriptHost::toNative(info.Holder());

- host->monitorFunction(scriptId, lineNumber, columnNumber, toWebCoreStringWithUndefinedOrNullCheck(name));

+ host->monitorFunction(scriptId, lineNumber, columnNumber, toCoreStringWithUndefinedOrNullCheck(name));

}

void V8InjectedScriptHost::unmonitorFunctionMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)