Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp - Issue 113213002: Rename toWebCoreString*() utility methods to toCoreString*()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp

Issue 113213002: Rename toWebCoreString*() utility methods to toCoreString*() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Keep "to" prefix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp ('k') | Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp

diff --git a/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp b/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp

index ea02ec71311326ba4880846876799f6b6991b73d..3e13d83e57e25d0bf7089e28e198c930bc6addb2 100644

--- a/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp

+++ b/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp

@@ -78,7 +78,7 @@ void V8CanvasRenderingContext2D::strokeStyleAttributeSetterCustom(v8::Local<v8::

{

CanvasRenderingContext2D* impl = V8CanvasRenderingContext2D::toNative(info.Holder());

if (value->IsString())

- impl->setStrokeColor(toWebCoreString(value.As<v8::String>()));

+ impl->setStrokeColor(toCoreString(value.As<v8::String>()));

else

impl->setStrokeStyle(toCanvasStyle(value, info.GetIsolate()));

}

@@ -93,7 +93,7 @@ void V8CanvasRenderingContext2D::fillStyleAttributeSetterCustom(v8::Local<v8::Va

{

CanvasRenderingContext2D* impl = V8CanvasRenderingContext2D::toNative(info.Holder());

if (value->IsString())

- impl->setFillColor(toWebCoreString(value.As<v8::String>()));

+ impl->setFillColor(toCoreString(value.As<v8::String>()));

else

impl->setFillStyle(toCanvasStyle(value, info.GetIsolate()));

}