Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: Source/bindings/v8/V8Binding.h

Issue 113213002: Rename toWebCoreString*() utility methods to toCoreString*() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Keep "to" prefix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptValue.cpp ('k') | Source/bindings/v8/V8Initializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8Binding.h
diff --git a/Source/bindings/v8/V8Binding.h b/Source/bindings/v8/V8Binding.h
index 70be2c44ca9a2e5670c664a50090b99775216f8d..4e43b873c64635c57eda58de18756f8db0ab72dd 100644
--- a/Source/bindings/v8/V8Binding.h
+++ b/Source/bindings/v8/V8Binding.h
@@ -156,26 +156,26 @@ namespace WebCore {
// Convert v8::String to a WTF::String. If the V8 string is not already
// an external string then it is transformed into an external string at this
// point to avoid repeated conversions.
- inline String toWebCoreString(v8::Handle<v8::String> value)
+ inline String toCoreString(v8::Handle<v8::String> value)
{
return v8StringToWebCoreString<String>(value, Externalize);
}
- inline String toWebCoreStringWithNullCheck(v8::Handle<v8::String> value)
+ inline String toCoreStringWithNullCheck(v8::Handle<v8::String> value)
{
if (value.IsEmpty() || value->IsNull())
return String();
- return toWebCoreString(value);
+ return toCoreString(value);
}
- inline String toWebCoreStringWithUndefinedOrNullCheck(v8::Handle<v8::String> value)
+ inline String toCoreStringWithUndefinedOrNullCheck(v8::Handle<v8::String> value)
{
if (value.IsEmpty() || value->IsNull() || value->IsUndefined())
return String();
- return toWebCoreString(value);
+ return toCoreString(value);
}
- inline AtomicString toWebCoreAtomicString(v8::Handle<v8::String> value)
+ inline AtomicString toCoreAtomicString(v8::Handle<v8::String> value)
{
return v8StringToWebCoreString<AtomicString>(value, Externalize);
}
@@ -187,7 +187,7 @@ namespace WebCore {
// FIXME: Replace all the call sites with V8TRYCATCH_FOR_V8STRINGRESOURCE().
// Using this method will lead to a wrong behavior, because you cannot stop the
// execution when an exception is thrown inside stringResource.prepare().
- inline String toWebCoreStringWithUndefinedOrNullCheck(v8::Handle<v8::Value> value)
+ inline String toCoreStringWithUndefinedOrNullCheck(v8::Handle<v8::Value> value)
{
V8StringResource<WithUndefinedOrNullCheck> stringResource(value);
if (!stringResource.prepare())
« no previous file with comments | « Source/bindings/v8/ScriptValue.cpp ('k') | Source/bindings/v8/V8Initializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698