Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 113213002: Rename toWebCoreString*() utility methods to toCoreString*() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Keep "to" prefix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestEventTarget.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 47d4e20106b3ba91e51990e32cce1ffe5750d8a4..9cac0b41728a4eb89c22963048583cb87f6694bb 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -3967,7 +3967,7 @@ sub GenerateImplementationNamedPropertyGetter
$code .= "\n";
$code .= " ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));\n";
$code .= " ${implClassName}* collection = ${v8ClassName}::toNative(info.Holder());\n";
- $code .= " AtomicString propertyName = toWebCoreAtomicString(name);\n";
+ $code .= " AtomicString propertyName = toCoreAtomicString(name);\n";
if ($raisesExceptions) {
$code .= " ExceptionState exceptionState(info.Holder(), info.GetIsolate());\n";
}
@@ -4086,7 +4086,7 @@ sub GenerateImplementationNamedPropertyDeleter
my $code = "static void namedPropertyDeleter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)\n";
$code .= "{\n";
$code .= " ${implClassName}* collection = ${v8ClassName}::toNative(info.Holder());\n";
- $code .= " AtomicString propertyName = toWebCoreAtomicString(name);\n";
+ $code .= " AtomicString propertyName = toCoreAtomicString(name);\n";
my $extraArguments = "";
if ($raisesExceptions) {
$code .= " ExceptionState exceptionState(info.Holder(), info.GetIsolate());\n";
@@ -4136,7 +4136,7 @@ sub GenerateImplementationNamedPropertyQuery
static void namedPropertyQuery(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
${implClassName}* collection = ${v8ClassName}::toNative(info.Holder());
- AtomicString propertyName = toWebCoreAtomicString(name);
+ AtomicString propertyName = toCoreAtomicString(name);
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
bool result = collection->namedPropertyQuery(propertyName, exceptionState);
if (exceptionState.throwIfNeeded())
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestEventTarget.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698