Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: Source/bindings/v8/ScriptPreprocessor.cpp

Issue 113213002: Rename toWebCoreString*() utility methods to toCoreString*() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Keep "to" prefix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/ScriptHeapSnapshot.cpp ('k') | Source/bindings/v8/ScriptProfiler.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 v8::Handle<v8::String> sourceCodeString = v8String(m_isolate, sourceCode); 97 v8::Handle<v8::String> sourceCodeString = v8String(m_isolate, sourceCode);
98 v8::Handle<v8::String> sourceNameString = v8String(m_isolate, sourceName); 98 v8::Handle<v8::String> sourceNameString = v8String(m_isolate, sourceName);
99 v8::Handle<v8::Value> argv[] = { sourceCodeString, sourceNameString, functio nName}; 99 v8::Handle<v8::Value> argv[] = { sourceCodeString, sourceNameString, functio nName};
100 100
101 v8::TryCatch tryCatch; 101 v8::TryCatch tryCatch;
102 tryCatch.SetVerbose(true); 102 tryCatch.SetVerbose(true);
103 TemporaryChange<bool> isPreprocessing(m_isPreprocessing, true); 103 TemporaryChange<bool> isPreprocessing(m_isPreprocessing, true);
104 v8::Handle<v8::Value> resultValue = V8ScriptRunner::callAsFunction(m_preproc essorFunction.newLocal(m_isolate), m_context.newLocal(m_isolate)->Global(), WTF_ ARRAY_LENGTH(argv), argv); 104 v8::Handle<v8::Value> resultValue = V8ScriptRunner::callAsFunction(m_preproc essorFunction.newLocal(m_isolate), m_context.newLocal(m_isolate)->Global(), WTF_ ARRAY_LENGTH(argv), argv);
105 105
106 if (!resultValue.IsEmpty() && resultValue->IsString()) 106 if (!resultValue.IsEmpty() && resultValue->IsString())
107 return toWebCoreStringWithNullCheck(resultValue.As<v8::String>()); 107 return toCoreStringWithNullCheck(resultValue.As<v8::String>());
108 108
109 return sourceCode; 109 return sourceCode;
110 } 110 }
111 111
112 } // namespace WebCore 112 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/ScriptHeapSnapshot.cpp ('k') | Source/bindings/v8/ScriptProfiler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698