Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1132123003: Run Clang plugin tests on the ToT bots (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 6 months ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run Clang plugin tests on the ToT bots BUG=452726 Committed: https://crrev.com/fcbe8dc0d1382fc678aad71873e068d13576c5b9 Cr-Commit-Position: refs/heads/master@{#330379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (3 generated)
hans
I haven't tried this locally yet, but figure I'd upload it and see what you ...
5 years, 7 months ago (2015-05-15 20:34:48 UTC) #2
Nico
Seems like a good idea to me.
5 years, 7 months ago (2015-05-15 21:17:25 UTC) #3
Nico
…except that the oilpan tests currently don't pass on Windows – would that turn the ...
5 years, 7 months ago (2015-05-15 21:17:47 UTC) #4
hans
On 2015/05/15 21:17:47, Nico wrote: > …except that the oilpan tests currently don't pass on ...
5 years, 7 months ago (2015-05-15 21:49:37 UTC) #5
Nico
lgtm, oilpan plugin tests now pass on windows (style plugin tests don't run on windows ...
5 years, 7 months ago (2015-05-17 04:16:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132123003/1
5 years, 7 months ago (2015-05-18 16:23:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 17:37:03 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fcbe8dc0d1382fc678aad71873e068d13576c5b9 Cr-Commit-Position: refs/heads/master@{#330379}
5 years, 7 months ago (2015-05-18 22:40:42 UTC) #10
Nico
It kind of looks like only the oilpan plugin tests run, not the style plugin ...
5 years, 6 months ago (2015-06-01 22:27:34 UTC) #11
hans
On 2015/06/01 22:27:34, Nico wrote: > It kind of looks like only the oilpan plugin ...
5 years, 6 months ago (2015-06-02 00:27:40 UTC) #12
hans
dcheng: any idea why cr-check-all only runs the oilpan tests on Windows, and not the ...
5 years, 6 months ago (2015-06-02 00:28:08 UTC) #14
dcheng
5 years, 6 months ago (2015-06-02 00:29:17 UTC) #15
Message was sent while issue was closed.
On 2015/06/02 at 00:28:08, hans wrote:
> dcheng: any idea why cr-check-all only runs the oilpan tests on Windows, and
not the style plugin tests?

Yes, I haven't had time to port the style plugin test harness =)

I was hoping to figure out some way to share more of the code between them
rather than just trying to copy/paste between them.

Powered by Google App Engine
This is Rietveld 408576698