Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 1132113007: [Effen] remove more CSS (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] remove more CSS This continues my attempt to remove our dependency on CSS. It adds support for column-based flex to FlexContainer. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6b453dcbf686ab204ea3d2134ffa860939f5a912

Patch Set 1 #

Patch Set 2 : base is now checked in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M sky/framework/components/radio.dart View 4 chunks +0 lines, -8 lines 0 comments Download
M sky/framework/components/scaffold.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M sky/framework/layout.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
5 years, 7 months ago (2015-05-14 20:19:54 UTC) #2
Hixie
5 years, 7 months ago (2015-05-14 20:20:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6b453dcbf686ab204ea3d2134ffa860939f5a912 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698