Issue 1132113005: [New Tab Page] Don't show tiles until all images are loaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1132113005: [New Tab Page] Don't show tiles until all images are loaded. (Closed)

Created:
5 years, 7 months ago by fserb

Modified:
5 years, 7 months ago

Reviewers:
Mathieu

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't show tiles until all images are loaded. Fix infinite loop bug on javascript. BUG=486879 Committed: https://crrev.com/627d0659772707bf5821062e873098c237c4b791 Cr-Commit-Position: refs/heads/master@{#329470}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -20 lines)			Patch
	M	chrome/browser/resources/local_ntp/most_visited_single.js	View		7 chunks	+20 lines, -20 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132113005/1

5 years, 7 months ago (2015-05-12 18:29:34 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-12 20:03:40 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/627d0659772707bf5821062e873098c237c4b791
Cr-Commit-Position: refs/heads/master@{#329470}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages