Issue 1132113004: Let Runtime_GrowArrayElements accept non-Smi numbers as |key|.

Issue 1132113004: Let Runtime_GrowArrayElements accept non-Smi numbers as |key|. (Closed)

Created:
5 years, 7 months ago by Jakob Kummerow

Modified:
5 years, 7 months ago

Reviewers:
mvstanton, jochen (gone - plz use gerrit), danno

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Let Runtime_GrowArrayElements accept non-Smi numbers as |key|. BUG=chromium:485410 LOG=y R=mvstanton@chromium.org,danno@chromium.org Committed: https://crrev.com/f10b992dabd8718f1f20e52f3a228f57da2d3b95 Cr-Commit-Position: refs/heads/master@{#28327}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	M	src/runtime/runtime-array.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-crbug-485410.js	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Total messages: 8 (2 generated)

Jakob Kummerow

We could force a Smi conversion in optimized code, but I figured making the runtime ...

5 years, 7 months ago (2015-05-08 23:58:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132113004/1

5 years, 7 months ago (2015-05-09 05:56:15 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/f10b992dabd8718f1f20e52f3a228f57da2d3b95 Cr-Commit-Position: refs/heads/master@{#28327}

5 years, 7 months ago (2015-05-09 10:31:07 UTC) #7

Message was sent while issue was closed.

LGTM. Thanks so much for catching that Jakob.