Issue 1132113003: fixes #177, FunctionDeclarationStatement and closing over `this`

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1132113003: fixes #177, FunctionDeclarationStatement and closing over `this` (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly

Modified:
5 years, 7 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fixes #177, FunctionDeclarationStatement and closing over `this` R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/49f0cb3d5036bdc6c85562d803014043ee5e7a83

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -86 lines)			Patch
M	lib/runtime/dart/_isolate_helper.js	View	5 chunks	+10 lines, -10 lines	0 comments	Download
M	lib/runtime/dart/_js_helper.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/runtime/dart/async.js	View	20 chunks	+38 lines, -38 lines	0 comments	Download
M	lib/runtime/dart/collection.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/runtime/dart/convert.js	View	5 chunks	+8 lines, -8 lines	0 comments	Download
M	lib/runtime/dart/core.js	View	11 chunks	+22 lines, -22 lines	0 comments	Download
M	lib/runtime/dart/isolate.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View	2 chunks	+7 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

https://codereview.chromium.org/1132113003/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1132113003/diff/1/lib/src/codegen/js_codegen.dart#newcode1072 lib/src/codegen/js_codegen.dart:1072: if (parent is FunctionDeclaration && AST is a little ...

5 years, 7 months ago (2015-05-08 21:49:39 UTC) #2

Jennifer Messerly

5 years, 7 months ago (2015-05-08 21:52:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
49f0cb3d5036bdc6c85562d803014043ee5e7a83 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages