Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issue 1132103004: Rename variables "request_handle" to "request" in CertVerifier tests. (Closed)

Created:
5 years, 7 months ago by eroman
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cert_refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename variables "request_handle" to "request" in CertVerifier tests. This follows the refactor of CertVerifier::RequestHandle --> CertVerifier::Request. BUG=475153 Committed: https://crrev.com/c8f859a652833c1997305d747683845aa98a7487 Cr-Commit-Position: refs/heads/master@{#330033}

Patch Set 1 #

Patch Set 2 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -85 lines) Patch
M chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc View 8 chunks +24 lines, -26 lines 0 comments Download
M net/cert/multi_threaded_cert_verifier_unittest.cc View 14 chunks +59 lines, -59 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
eroman
5 years, 7 months ago (2015-05-09 01:42:34 UTC) #2
Ryan Sleevi
lgtm
5 years, 7 months ago (2015-05-09 01:43:59 UTC) #3
eroman
TRB pneubeck@chromium.org for changes to chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc
5 years, 7 months ago (2015-05-11 22:10:20 UTC) #4
eroman
Actually add pneubeck@chromium.org this time (TBR for cromeos change)
5 years, 7 months ago (2015-05-11 22:11:20 UTC) #6
eroman
(Won't commit this until later in the week, in case the dependent CL ends up ...
5 years, 7 months ago (2015-05-11 23:09:31 UTC) #7
pneubeck (no reviews)
lgtm
5 years, 7 months ago (2015-05-12 09:21:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132103004/20001
5 years, 7 months ago (2015-05-15 02:47:32 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 03:10:55 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 03:11:41 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c8f859a652833c1997305d747683845aa98a7487
Cr-Commit-Position: refs/heads/master@{#330033}

Powered by Google App Engine
This is Rietveld 408576698