Add metrics to record TCP/UDP connections made from Flash

content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

Index: content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
diff --git a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
index f29fc977fe941c7c035940cdabc2f094dc62c42f..775e7c611936543e240a2b4ca1259fbd104b7ec0 100644
--- a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
+++ b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
@@ -17,6 +17,7 @@
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/resource_context.h"
+#include "content/public/browser/user_metrics.h"
 #include "content/public/common/socket_permission_request.h"
 #include "net/base/address_family.h"
 #include "net/base/host_port_pair.h"
@@ -1000,6 +1001,13 @@ void PepperTCPSocketMessageFilter::SendConnectReply(
     int32_t pp_result,
     const PP_NetAddress_Private& local_addr,
     const PP_NetAddress_Private& remote_addr) {
+  if (pp_result == PP_OK && host_->IsPrivilegedContext(instance_)) {
+    content::RecordAction(base::UserMetricsAction("Pepper_TCPConnect_Secure"));
+  } else {

[jww, 2015/05/12 02:47:47]

shouldn't this be "else if (pp_result == PP_OK)" or alternatively shouldn't you
factor out the pp_result == PP_OK to an 'if' surrounding the whole thing? That
is, I think you only want to record Pepper_TCPConnect_Insecure if pp_result ==
PP_OK.

[raymes, 2015/05/12 04:56:44]

Oops, done. I actually took out the check altogether. I was in two minds about
it but I've decided just to record all attempts.

+    content::RecordAction(
+        base::UserMetricsAction("Pepper_TCPConnect_Insecure"));
+  }
+
   ppapi::host::ReplyMessageContext reply_context(context);
   reply_context.params.set_result(pp_result);
   SendReply(reply_context,