Add metrics to record TCP/UDP connections made from Flash

content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/pepper/browser_ppapi_host_impl.h"
 
 #include "base/metrics/sparse_histogram.h"
 #include "content/browser/renderer_host/pepper/pepper_message_filter.h"
 #include "content/browser/tracing/trace_message_filter.h"
 #include "content/common/pepper_renderer_instance_data.h"
@@ skipping 123 matching lines @@
   if (data == nullptr)
     return GURL();
   return data->renderer_data.plugin_url;
 }
 
 void BrowserPpapiHostImpl::SetOnKeepaliveCallback(
     const BrowserPpapiHost::OnKeepaliveCallback& callback) {
   on_keepalive_callback_ = callback;
 }
 
+bool BrowserPpapiHostImpl::IsPotentiallySecurePluginContext(
+    PP_Instance instance) {
+  auto* data = instance_map_.get(instance);

[Ryan Sleevi, 2015/05/12 22:56:05]

nit: why the auto*? Why not let auto bind to the appropriate type?

[dcheng, 2015/05/12 23:56:20]

(I'm not raymes@ but I personally prefer auto* when appropriate, to make it
clear that there's no accidental copy happening)

[raymes, 2015/05/13 00:07:19]

I copied the code from other functions in here. I've changed it.

[raymes, 2015/05/13 00:08:00]

based on dcheng's comment, I left it as-is :P but really I don't feel strongly.

+  if (data == nullptr)
+    return false;
+  return data->renderer_data.is_potentially_secure_plugin_context;
+}
+
 void BrowserPpapiHostImpl::AddInstance(
     PP_Instance instance,
     const PepperRendererInstanceData& renderer_instance_data) {
   DCHECK(!instance_map_.contains(instance));
   instance_map_.add(instance,
                     make_scoped_ptr(new InstanceData(renderer_instance_data)));
 }
 
 void BrowserPpapiHostImpl::DeleteInstance(PP_Instance instance) {
   int erased = instance_map_.erase(instance);
@@ skipping 102 matching lines @@
         instance->second->renderer_data.render_frame_id;
     instance_data[i].document_url =
         instance->second->renderer_data.document_url;
     ++instance;
     ++i;
   }
   on_keepalive_callback_.Run(instance_data, profile_data_directory_);
 }
 
 }  // namespace content