Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1132083005: pkg/path: migrate to pkg/test (Closed)

Created:
5 years, 7 months ago by kevmoo
Modified:
5 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/path.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

migrate to pkg/test

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M pubspec.yaml View 1 chunk +3 lines, -3 lines 2 comments Download
M test/browser_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M test/io_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M test/path_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/posix_test.dart View 1 chunk +3 lines, -1 line 2 comments Download
M test/relative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/url_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/windows_test.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kevmoo
5 years, 7 months ago (2015-05-13 06:16:32 UTC) #2
nweiz
Make sure you update .status as well; at the very least, the old status declarations ...
5 years, 7 months ago (2015-05-13 18:06:31 UTC) #3
nweiz
5 years, 7 months ago (2015-05-13 18:07:28 UTC) #4
https://codereview.chromium.org/1132083005/diff/1/test/posix_test.dart
File test/posix_test.dart (right):

https://codereview.chromium.org/1132083005/diff/1/test/posix_test.dart#newcode5
test/posix_test.dart:5: @TestOn('posix && vm')
On 2015/05/13 18:06:31, nweiz wrote:
> "&& vm" is unnecessary here. All the OS selectors imply "vm".

Oh, sorry, I wasn't thinking: this test isn't OS-dependent at all. It just sets
up its own context. Get rid of @TestOn entirely (also in windows_test).

Powered by Google App Engine
This is Rietveld 408576698