Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 1132083003: Makes ResourceLoader own handles and return Files (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes ResourceLoader own handles and return Files This way it won't leak if destroyed. Also cleaned up html_viewer's use of ResourceLoader. R=ben@chromium.org TBR=ben@chromium.org BUG=none TEST=none Committed: https://crrev.com/6e4a8779b6f3cf90d4d69356f499db025e891c5a Cr-Commit-Position: refs/heads/master@{#329295}

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -28 lines) Patch
M components/html_viewer/BUILD.gn View 4 chunks +11 lines, -0 lines 0 comments Download
M components/html_viewer/html_viewer.cc View 1 6 chunks +25 lines, -16 lines 0 comments Download
A components/html_viewer/html_viewer_resources.grd View 1 chunk +11 lines, -0 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.h View 3 chunks +12 lines, -4 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 4 chunks +14 lines, -3 lines 0 comments Download
M components/resource_provider/resource_provider_apptest.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 7 months ago (2015-05-11 23:52:41 UTC) #1
sky
I'm TBRing as without this windows is likely broke.
5 years, 7 months ago (2015-05-11 23:57:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132083003/20001
5 years, 7 months ago (2015-05-12 00:01:11 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 00:29:05 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 00:29:51 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e4a8779b6f3cf90d4d69356f499db025e891c5a
Cr-Commit-Position: refs/heads/master@{#329295}

Powered by Google App Engine
This is Rietveld 408576698