Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1132043002: Refresh button for FrE and recovery modes added to enrollment screen. (Closed)

Created:
5 years, 7 months ago by dzhioev (left Google)
Modified:
5 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gaia_icon_button
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refresh button for FrE and recovery modes added to enrollment screen. In addition fixed an issue where <- button was shown when it should not. BUG=472671 TEST=manually,tested FrE and recovery modes, button works as expected. Committed: https://crrev.com/f46f86c6c0b32fdc98b7c27ace907de67d735fe8 Cr-Commit-Position: refs/heads/master@{#329361}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.css View 1 2 3 chunks +26 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dzhioev (left Google)
Thiemo, please take a look.
5 years, 7 months ago (2015-05-08 05:36:04 UTC) #2
dzhioev (left Google)
On 2015/05/08 05:36:04, dzhioev wrote: > Thiemo, please take a look. NOTE: this CL is ...
5 years, 7 months ago (2015-05-08 05:39:49 UTC) #3
dzhioev (left Google)
https://codereview.chromium.org/1133733003/ is landed now. Nikita, you have more expertise than Thiemo in this area, so ...
5 years, 7 months ago (2015-05-12 00:06:46 UTC) #5
Nikita (slow)
lgtm
5 years, 7 months ago (2015-05-12 05:43:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132043002/40001
5 years, 7 months ago (2015-05-12 05:43:42 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 06:09:40 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 06:10:25 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f46f86c6c0b32fdc98b7c27ace907de67d735fe8
Cr-Commit-Position: refs/heads/master@{#329361}

Powered by Google App Engine
This is Rietveld 408576698