Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/fontconfig/README.chromium

Issue 113203003: Fix Mac fontconfig build (Closed) Base URL: https://skia.googlesource.com/skia.git@noembed
Patch Set: checkpoint Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gyp/gm.gyp ('K') | « gyp/gm.gyp ('k') | third_party/fontconfig/config/mac/config.h » ('j') | third_party/fontconfig/process-template.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/fontconfig/README.chromium
diff --git a/third_party/fontconfig/README.chromium b/third_party/fontconfig/README.chromium
index f9ea5b62b3a06d4e89467c2c7ac81a0aa1d8ebe9..5169720cd6a873899ef7749af3e42781523b7493 100644
--- a/third_party/fontconfig/README.chromium
+++ b/third_party/fontconfig/README.chromium
@@ -33,9 +33,15 @@ third_party/fontconfig/config:
fc-lang/fclang.h
src/fcobjshash.h
-On Linux and Mac, these are the files generated by ./configure, with no
+On Mac, these are the files generated by
+ ./configure --with-add-fonts=/System/Library/Fonts,/Library/Fonts
additional flags.
epoger 2014/01/08 19:40:22 remove this "additional flags." line?
vandebo (ex-Chrome) 2014/01/08 21:24:15 Oops. Done.
+config/mac/config.h.template then has a section added to the top:
+
++/* Manually added template defines */
++#define FC_CACHEDIR "@FC_CACHEDIR@"
++#define FONTCONFIG_PATH "@FONTCONFIG_PATH@"
+
On Windows, the configuration files were from
http://comments.gmane.org/gmane.comp.fonts.fontconfig/4438
(fontconfig development list).
-
« gyp/gm.gyp ('K') | « gyp/gm.gyp ('k') | third_party/fontconfig/config/mac/config.h » ('j') | third_party/fontconfig/process-template.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698