Fix Mac fontconfig build

third_party/fontconfig/process-template.py

+#!/usr/bin/python

[epoger, 2014/01/08 19:40:22]

Add copyright and documentation header?

+
+import argparse
+import os
+import sys
+
+parser = argparse.ArgumentParser()
+parser.add_argument("-i", "--input")

[epoger, 2014/01/08 19:40:22]

Please be consistent with either single- or double-quotes for Python string
constants, as per
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=String...

I've seen much more use of single-quotes in our Python code (but double-quotes
for docstrings).

[vandebo (ex-Chrome), 2014/01/08 21:24:15]

Done.

+parser.add_argument("-o", "--output")
+parser.add_argument(

[epoger, 2014/01/08 19:40:22]

I would suggest naming this arg --keyword_substitution (-k), for symmetry with
--path_substitution (-p).

[vandebo (ex-Chrome), 2014/01/08 21:24:15]

Done.

+    "-s", "--substitution",  action="append", nargs=2, metavar=('KEY', 'VALUE'),    help="Changes @KEY@ to VALUE in the template.")

[bungeman-skia, 2014/01/07 21:13:29]

nit: this line is a bit long, looks like the next one (-p) is nicely formatted.

[vandebo (ex-Chrome), 2014/01/08 21:24:15]

Done.

+parser.add_argument(
+    "-p", "--path_substitution", action="append", nargs=2,
+    metavar=('KEY', 'PATH'),
+    help="Makes PATH absolute then changes @KEY@ to PATH in the template.")
+
+args = parser.parse_args()
+
+input = sys.stdin
+if args.input:
+  try:
+    input = open(args.input, 'r')
+  except IOError:

[epoger, 2014/01/08 19:40:22]

Why the manual try/except handling?  If you just don't bother, won't the default
exception handling provide what you want, with more information yielded to the
developer?

[vandebo (ex-Chrome), 2014/01/08 21:24:15]

Done.

+    sys.exit(1)
+
+output = sys.stdout
+if args.output:
+  try:
+    output = open(args.output, 'w')
+  except IOError:
+    sys.exit(1)
+
+path_subs = None
+if args.path_substitution:
+  path_subs = [
+      [sub[0], os.path.abspath(sub[1])] for sub in args.path_substitution
+  ]
+
+for line in input:
+  if args.substitution:
+    for (key, value) in args.substitution:
+      line = line.replace('@' + key + '@', value)

[epoger, 2014/01/08 19:40:22]

Rather than mandating the @ delimiters, why not just let the caller pass in
whatever key she wants?  ("@FC_CACHEDIR@", "%%FC_CACHEDIR%%", or whatever is
desired)

[vandebo (ex-Chrome), 2014/01/08 21:24:15]

Done.

+  if path_subs:
+    for (key, path) in path_subs:
+      line = line.replace('@' + key + '@', path)
+  output.write(line)
+
+input.close()
+output.close()