Fix Mac fontconfig build

gyp/common_variables.gypi

 # Copyright 2012 The Android Open Source Project
 #
 # Use of this source code is governed by a BSD-style license that can be

[epoger, 2014/01/08 19:40:22]

Toplevel questions:

1. You say "Populating the cache directory can take some time, but should only
happen on a clean build."  Why is that so?  I would think that a cache directory
is something that would be constructed at RUNTIME, not COMPILE TIME.  (My
ignorance of fontconfig is showing!)

2. You say "To remove this extra time, we have to not build poppler on Mac,
which can now be accomplished with GYP_DEFINES="skia_mac_poppler=0""  What's the
relationship between fontconfig cache directory and poppler?

[vandebo (ex-Chrome), 2014/01/08 21:24:15]

The fontconfig works when it's installed on a system is that install time, it
walks all the fonts and generates the cache directory.  When a new font is added
the cache is updated.  So usually the cache is generated at install time (not
compile time).

In this case, we're doing a skia local install, into the output directory. 
Since we're not touching fontconfig, the only time the cache will need to be
updated is when the output directory gets clobbered.
poppler depends on fontconfig.  If fontconfig's cache directory is not present
then fontconfig and poppler will fail to find fonts that are not embedded in the
PDF.

 # found in the LICENSE file.
 
 {
   # Get ready for the ugly...
   #
   # - We have to nest our variables dictionaries multiple levels deep, so that
   #   this and other gyp files can rely on previously-set variable values in
   #   their 'variables': { 'conditions': [] } clauses.
   #
   #   Example 1:
@@ skipping 75 matching lines @@
       'skia_angle%': 0,
       'skia_chrome_utils%': 1,
       'skia_directwrite%': 0,
       'skia_gpu%': 1,
       'skia_osx_sdkroot%': '',
       'skia_profile_enabled%': 0,
       'skia_win_debuggers_path%': '',
       'skia_shared_lib%': 0,
       'skia_opencl%': 0,
       'skia_distancefield_fonts%': 0,
+      'skia_mac_poppler%': 1,

[bungeman-skia, 2014/01/07 21:13:29]

It looks like the actual meaning of this variable is whether the gm tool (or any
tool) should depend on poppler or not. Maybe something like skia_poppler_enabled
and the logic. Come to think of it, what is really wanted here is a
skia_init_fontconfig to control if fontconfig should be set up or not. (This
would directly control the new dependencies added in gyp/fontconfig.gyp.)

[vandebo (ex-Chrome), 2014/01/08 21:24:15]

We don't want to have poppler without fontconfig installed/initialized - you'll
get spew from poppler and bad output.  But your other points are right, changed
to skia_poppler_enabled and made it not mac specific.

 
       # These variables determine the default optimization level for different
       # compilers.
       'skia_default_vs_optimization_level': 3, # full (/Ox)
       'skia_default_gcc_optimization_level': 3, # -O3
     },
 
     'conditions': [
       [ 'skia_os == "win" and skia_arch_width == 32 or '
         'skia_os in ["linux", "freebsd", "openbsd", "solaris", "android"] or '
@@ skipping 41 matching lines @@
     'skia_arch_type%': '<(skia_arch_type)',
     'skia_chrome_utils%': '<(skia_chrome_utils)',
     'skia_directwrite%': '<(skia_directwrite)',
     'skia_gpu%': '<(skia_gpu)',
     'skia_win_exceptions%': 0,
     'skia_osx_sdkroot%': '<(skia_osx_sdkroot)',
     'skia_profile_enabled%': '<(skia_profile_enabled)',
     'skia_shared_lib%': '<(skia_shared_lib)',
     'skia_opencl%': '<(skia_opencl)',
     'skia_distancefield_fonts%': '<(skia_distancefield_fonts)',
+    'skia_mac_poppler%': '<(skia_mac_poppler)',
     'skia_static_initializers%': '<(skia_static_initializers)',
     'ios_sdk_version%': '6.0',
     'skia_win_debuggers_path%': '<(skia_win_debuggers_path)',
     'skia_run_pdfviewer_in_gm%': 0,
 
     # These are referenced by our .gypi files that list files (e.g. core.gypi)
     #
     'skia_src_path%': '../src',
     'skia_include_path%': '../include',
   },
 }