[Sync] Refactoring polling to be reliable.

[Sync] Refactoring polling to be reliable.

Polling is now an important component of sync health, as it can sometimes be
the only time we'll query for certain datatypes. As such, the following
has changed:
- Polls that fail will be retried (with backoff).
- As such, the logic to force a poll after an auth error isn't needed anymore
- The last successful poll time will be persisted in the sync prefs.
- On startup, schedule the first poll for last_poll_time + poll_interval
  (or Now(), whichever is latest).
- Receiving a new poll interval from the server will update the poll timer
- The poll timer is now a one shot timer, and only restarts on success
- Some code cleanup to make the above more straightforward

BUG=482154
Committed: https://crrev.com/3777d8727d7b4caedfb72bfdcbe2fea1f1d1d594
Cr-Commit-Position: refs/heads/master@{#329669}

[Nicolas Zea, 2015-05-07 23:50:11]

zea@chromium.org changed reviewers:
+ pavely@chromium.org

[Nicolas Zea, 2015-05-07 23:50:12]

+Pavel, PTAL

Sorry for the size of the CL but nearly everything outside of the
scheduler/tests is just plumbing changes to move the polling time around.

[pavely, 2015-05-08 23:04:13]

lstm with minor comments.

https://codereview.chromium.org/1132013004/diff/60001/sync/engine/sync_schedu...
File sync/engine/sync_scheduler_impl.cc (right):

https://codereview.chromium.org/1132013004/diff/60001/sync/engine/sync_schedu...
sync/engine/sync_scheduler_impl.cc:10: #include "base/auto_reset.h"
I think auto_reset.h is not needed anymore.

https://codereview.chromium.org/1132013004/diff/60001/sync/engine/syncer.h
File sync/engine/syncer.h (right):

https://codereview.chromium.org/1132013004/diff/60001/sync/engine/syncer.h#ne...
sync/engine/syncer.h:104: DISALLOW_COPY_AND_ASSIGN(Syncer);
nit: DISALLOW_COPY_AND_ASSIGN should be the last thing in the class.

[pavely, 2015-05-08 23:05:07]

On 2015/05/08 23:04:13, pavely wrote:
> lstm with minor comments.
> 
>
https://codereview.chromium.org/1132013004/diff/60001/sync/engine/sync_schedu...
> File sync/engine/sync_scheduler_impl.cc (right):
> 
>
https://codereview.chromium.org/1132013004/diff/60001/sync/engine/sync_schedu...
> sync/engine/sync_scheduler_impl.cc:10: #include "base/auto_reset.h"
> I think auto_reset.h is not needed anymore.
> 
> https://codereview.chromium.org/1132013004/diff/60001/sync/engine/syncer.h
> File sync/engine/syncer.h (right):
> 
>
https://codereview.chromium.org/1132013004/diff/60001/sync/engine/syncer.h#ne...
> sync/engine/syncer.h:104: DISALLOW_COPY_AND_ASSIGN(Syncer);
> nit: DISALLOW_COPY_AND_ASSIGN should be the last thing in the class.

I meant lgtm

[Nicolas Zea, 2015-05-09 17:23:59]

Thanks for the quick review! Comments addressed.

[Nicolas Zea, 2015-05-09 17:24:15]

The CQ bit was checked by zea@chromium.org

[Nicolas Zea, 2015-05-09 17:24:16]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/1132013004/#ps80001
(title: "Address comments")

[commit-bot: I haz the power, 2015-05-09 17:26:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132013004/80001

[commit-bot: I haz the power, 2015-05-09 21:30:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-09 21:31:00]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  cast_shell_android on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Nicolas Zea, 2015-05-13 16:44:45]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2015-05-13 16:45:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132013004/80001

[commit-bot: I haz the power, 2015-05-13 17:43:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-13 17:44:13]

Patchset 5 (id:??) landed as
https://crrev.com/3777d8727d7b4caedfb72bfdcbe2fea1f1d1d594
Cr-Commit-Position: refs/heads/master@{#329669}

[Nicolas Zea, 2015-05-13 18:44:07]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1144443004/ by zea@chromium.org.

The reason for reverting is: Failing on valgrind bots.