Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: content/renderer/context_menu_params_builder.cc

Issue 1131993009: Remove the usage of WebElement::innerText in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed serializer test. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/dom_serializer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/context_menu_params_builder.cc
diff --git a/content/renderer/context_menu_params_builder.cc b/content/renderer/context_menu_params_builder.cc
index 63dcd4d1e7b6b3c5b903b9dac8906f4e88882da2..d81fa13d17cc0996fe4eb28ac5a85989cef1b3b4 100644
--- a/content/renderer/context_menu_params_builder.cc
+++ b/content/renderer/context_menu_params_builder.cc
@@ -59,7 +59,7 @@ ContextMenuParams ContextMenuParamsBuilder::Build(
blink::WebNode selectedNode = DomUtils::ExtractParentAnchorNode(data.node);
blink::WebElement selectedElement = selectedNode.to<blink::WebElement>();
if (!selectedElement.isNull() && selectedNode.isLink()) {
- params.link_text = selectedElement.innerText();
+ params.link_text = selectedElement.textContent();
} else {
LOG(ERROR) << "Creating a ContextMenuParams for a node that has a link"
<< "url but is not an ElementNode or does not have an"
« no previous file with comments | « no previous file | content/renderer/dom_serializer_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698