Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1131993009: Remove the usage of WebElement::innerText in Chromium. (Closed)

Created:
5 years, 7 months ago by dglazkov
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the usage of WebElement::innerText in Chromium. This is part 2 of removing WebElement::innerText. BUG=488088 R=jochen@chromium.org Committed: https://crrev.com/3c1f64f9c822002263d9f0aa4e5e02cebb26671f Cr-Commit-Position: refs/heads/master@{#330127}

Patch Set 1 #

Patch Set 2 : Fixed serializer test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M content/renderer/context_menu_params_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/dom_serializer_browsertest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131993009/1
5 years, 7 months ago (2015-05-14 21:37:25 UTC) #2
jam
lgtm
5 years, 7 months ago (2015-05-14 21:48:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/89123)
5 years, 7 months ago (2015-05-14 21:55:20 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-15 13:54:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131993009/1
5 years, 7 months ago (2015-05-15 14:36:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/18406)
5 years, 7 months ago (2015-05-15 15:16:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131993009/20001
5 years, 7 months ago (2015-05-15 16:43:34 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 17:51:05 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 17:52:52 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c1f64f9c822002263d9f0aa4e5e02cebb26671f
Cr-Commit-Position: refs/heads/master@{#330127}

Powered by Google App Engine
This is Rietveld 408576698