net/base/sdch_dictionary.cc - Issue 1131963003: Switch //net functions to use SchemeIsCryptographic() instead of SchemeIsSecure().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/sdch_dictionary.cc

Issue 1131963003: Switch //net functions to use SchemeIsCryptographic() instead of SchemeIsSecure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/sdch_dictionary.cc

diff --git a/net/base/sdch_dictionary.cc b/net/base/sdch_dictionary.cc

index 59297dae277a5693a24792cfec23b7013ba610cb..6e4abe10247c3f4945bb8b17efcf0da4da111a55 100644

--- a/net/base/sdch_dictionary.cc

+++ b/net/base/sdch_dictionary.cc

@@ -128,7 +128,7 @@ SdchProblemCode SdchDictionary::CanUse(const GURL& target_url) const {

if (path_.size() && !PathMatch(target_url.path(), path_))

return SDCH_DICTIONARY_FOUND_HAS_WRONG_PATH;

- if (target_url.SchemeIsSecure() != url_.SchemeIsSecure())

+ if (target_url.SchemeIsCryptographic() != url_.SchemeIsCryptographic())

return SDCH_DICTIONARY_FOUND_HAS_WRONG_SCHEME;

// TODO(jar): Remove overly restrictive failsafe test (added per security

« no previous file with comments | « no previous file | net/base/sdch_manager.cc » ('j') | net/base/sdch_manager.cc » ('J')