Issue 1131953006: Shell: switches cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131953006: Shell: switches cleanup. (Closed)

Created:
5 years, 7 months ago by viettrungluu

Modified:
5 years, 7 months ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Shell: switches cleanup. * Make //shell/application_manager stop depending on //shell:switches. * Add child_switches.{cc,h}. That goes in :common_lib (since obviously both the parent and child need them. * switches.{cc,h} can go in :parent_lib (formerly known as :lib), instead of being in a target of its own. R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/988b4be018295f2da3bd0ea6e56a296a74dac1c2

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -58 lines)			Patch
M	services/gles2/BUILD.gn	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	shell/BUILD.gn	View		7 chunks	+7 lines, -19 lines	0 comments	Download
M	shell/application_manager/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	shell/application_manager/application_manager.h	View		5 chunks	+9 lines, -3 lines	0 comments	Download
M	shell/application_manager/application_manager.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	shell/application_manager/application_manager_unittest.cc	View		5 chunks	+6 lines, -5 lines	0 comments	Download
M	shell/application_manager/network_fetcher.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	shell/application_manager/network_fetcher.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	shell/child_main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	shell/child_process_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	shell/child_switches.h	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A +	shell/child_switches.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	shell/context.cc	View		3 chunks	+13 lines, -4 lines	0 comments	Download
M	shell/native_runner_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	shell/shell_test_main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	shell/switches.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	shell/switches.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

viettrungluu

5 years, 7 months ago (2015-05-15 20:00:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
988b4be018295f2da3bd0ea6e56a296a74dac1c2 (presubmit successful).