Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9536)

Unified Diff: content/child/background_sync/background_sync_provider.h

Issue 1131943005: [Background Sync] Add proper error status to API calls and callbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split RegisterCallback into two methods Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/background_sync/background_sync_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/background_sync/background_sync_provider.h
diff --git a/content/child/background_sync/background_sync_provider.h b/content/child/background_sync/background_sync_provider.h
index 93d4fefbd732db5e6b161b7ded6305d2d9665859..25d6f28ddb2226975716b7ab23030429c819a19d 100644
--- a/content/child/background_sync/background_sync_provider.h
+++ b/content/child/background_sync/background_sync_provider.h
@@ -52,12 +52,18 @@ class BackgroundSyncProvider : public blink::WebSyncProvider {
// Callback handlers
void RegisterCallback(
scoped_ptr<blink::WebSyncRegistrationCallbacks> callbacks,
+ BackgroundSyncError error,
const SyncRegistrationPtr& options);
void UnregisterCallback(
scoped_ptr<blink::WebSyncUnregistrationCallbacks> callbacks,
- bool success);
+ BackgroundSyncError error);
+ void GetRegistrationCallback(
+ scoped_ptr<blink::WebSyncRegistrationCallbacks> callbacks,
+ BackgroundSyncError error,
+ const SyncRegistrationPtr& options);
void GetRegistrationsCallback(
scoped_ptr<blink::WebSyncGetRegistrationsCallbacks> callbacks,
+ BackgroundSyncError error,
const mojo::Array<SyncRegistrationPtr>& registrations);
// Helper method that returns an initialized BackgroundSyncServicePtr.
« no previous file with comments | « no previous file | content/child/background_sync/background_sync_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698