Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131933009: Making Mandoline apps notice when all the objects they vended are gone so that it can terminate. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Making Mandoline apps notice when all the objects they vended are gone so that it can terminate. With this change, closing the window shuts down Mandoline cleanly. This is split off https://codereview.chromium.org/1139673003 BUG=484234 Committed: https://crrev.com/e152cdb102e5e495dd3aa124a512ea750b47c04c Cr-Commit-Position: refs/heads/master@{#330550}

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -48 lines) Patch
M components/native_viewport/native_viewport_application_delegate.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/native_viewport/native_viewport_application_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/native_viewport/native_viewport_impl.h View 3 chunks +4 lines, -1 line 0 comments Download
M components/native_viewport/native_viewport_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.h View 2 chunks +3 lines, -0 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 6 chunks +14 lines, -8 lines 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/application/app_lifetime_helper.h View 1 chunk +76 lines, -0 lines 0 comments Download
A mojo/application/app_lifetime_helper.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M mojo/runner/android/native_viewport_application_loader.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M mojo/services/network/cookie_store_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M mojo/services/network/cookie_store_impl.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M mojo/services/network/http_server_impl.h View 4 chunks +5 lines, -1 line 0 comments Download
M mojo/services/network/http_server_impl.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M mojo/services/network/network_service_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/services/network/network_service_impl.h View 3 chunks +4 lines, -1 line 0 comments Download
M mojo/services/network/network_service_impl.cc View 3 chunks +14 lines, -8 lines 0 comments Download
M mojo/services/network/tcp_bound_socket_impl.h View 3 chunks +3 lines, -1 line 0 comments Download
M mojo/services/network/tcp_bound_socket_impl.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/network/tcp_server_socket_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M mojo/services/network/tcp_server_socket_impl.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/services/network/udp_socket_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M mojo/services/network/udp_socket_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/services/network/url_loader_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M mojo/services/network/url_loader_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/network/url_loader_impl_apptest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/network/web_socket_impl.h View 3 chunks +4 lines, -1 line 0 comments Download
M mojo/services/network/web_socket_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 7 months ago (2015-05-19 15:53:56 UTC) #2
Elliot Glaysher
lgtm
5 years, 7 months ago (2015-05-19 17:16:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131933009/20001
5 years, 7 months ago (2015-05-19 17:27:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 17:36:21 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:37:16 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e152cdb102e5e495dd3aa124a512ea750b47c04c
Cr-Commit-Position: refs/heads/master@{#330550}

Powered by Google App Engine
This is Rietveld 408576698