Issue 1131933005: Sign in Now to GCM, only when user is signed in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131933005: Sign in Now to GCM, only when user is signed in. (Closed)

Created:
5 years, 7 months ago by skare_

Modified:
5 years, 7 months ago

Reviewers:
robliao

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@gcm

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Register Now for GCM, only when user is signed in. BUG=480733 Committed: https://crrev.com/b4b130888f0bff38e04a2e127ceb86bf22ae518e Cr-Commit-Position: refs/heads/master@{#330236}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	chrome/browser/resources/google_now/background.js	View	1	3 chunks	+8 lines, -3 lines	0 comments	Download

Total messages: 7 (2 generated)

robliao

On 2015/05/15 20:54:10, skare_ wrote: Those unit tests took longer than I expected to build. ...

5 years, 7 months ago (2015-05-15 21:32:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131933005/20001

5 years, 7 months ago (2015-05-15 22:04:55 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-18 11:29:20 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/b4b130888f0bff38e04a2e127ceb86bf22ae518e
Cr-Commit-Position: refs/heads/master@{#330236}