Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 1131933004: Revert "Remove test result whitespace stripping from blink_gc_plugin test script" (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 7 months ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Remove test result whitespace stripping from blink_gc_plugin test script" This reverts https://crrev.com/5171d85366fe1bd7c1de43e866adc3c3e50bc419 BUG=none TBR=thakis Committed: https://crrev.com/3f5aeb5d2f932a971a0e6fa1da2c6253e4dba103 Cr-Commit-Position: refs/heads/master@{#330184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M tools/clang/blink_gc_plugin/tests/cycle_ptrs.txt View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/cycle_sub.txt View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/cycle_super.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + tools/clang/blink_gc_plugin/tests/cycle_super_neg.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/register_weak_members_template.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/test.py View 4 chunks +17 lines, -24 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/trace_after_dispatch_impl.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/traceimpl.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/traceimpl_derived_from_templated_base.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/traceimpl_omitted_trace.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/traceimpl_overloaded.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
hans
cq couldn't land https://codereview.chromium.org/1139113004/ for some reason, so trying this manually instead.
5 years, 7 months ago (2015-05-15 20:20:52 UTC) #2
Nico
rs-lgtm
5 years, 7 months ago (2015-05-15 20:22:51 UTC) #3
hans
Committed patchset #1 (id:1) manually as 3f5aeb5d2f932a971a0e6fa1da2c6253e4dba103 (presubmit successful).
5 years, 7 months ago (2015-05-15 20:23:16 UTC) #4
dcheng
Bah, I tested this on Linux and Windows. On Sat, May 16, 2015, 06:23 <reply@chromiumcodereview-hr.appspotmail.com> ...
5 years, 7 months ago (2015-05-15 22:35:34 UTC) #5
Nico
(FWIW, from what I can currently tell, 8 of the test failures on Windows are ...
5 years, 7 months ago (2015-05-15 23:06:25 UTC) #6
Nico
Yep, this doesn't work on windows for me. On May 15, 2015 4:06 PM, "Nico ...
5 years, 7 months ago (2015-05-15 23:17:22 UTC) #7
325583992843-0clp48nf3nc7pk3ll9lp3k65k4ra53j4
Patchset 1 (id:??) landed as https://crrev.com/3f5aeb5d2f932a971a0e6fa1da2c6253e4dba103 Cr-Commit-Position: refs/heads/master@{#330184}
5 years, 7 months ago (2015-05-16 05:29:51 UTC) #8
dcheng
I'm going to go ahead and blame ɐᴉlɐɹʇsn∀. Sorry =( I'll try to figure this ...
5 years, 7 months ago (2015-05-16 08:55:01 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:26:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f5aeb5d2f932a971a0e6fa1da2c6253e4dba103
Cr-Commit-Position: refs/heads/master@{#330184}

Powered by Google App Engine
This is Rietveld 408576698