Issue 1131933003: Load time improvements (fixes #140)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131933003: Load time improvements (fixes #140) (Closed)

Created:
5 years, 7 months ago by Siggi Cherem (dart-lang)

Modified:
5 years, 7 months ago

Reviewers:
vsm, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Load time improvements (fixes #140): - move hash to a query parameter (it works!) - do widget request later, let app render/loading in case the request is fast enough. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/5de8fbf91cb50eca1ddacf65db2467f830246db0

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1199 lines, -1078 lines)			Patch
M	lib/devc.dart	View	1 chunk	+6 lines, -12 lines	0 comments	Download
M	lib/runtime/messages_widget.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	lib/runtime/messages_widget.js	View	185 chunks	+1186 lines, -1063 lines	0 comments	Download
M	lib/src/codegen/html_codegen.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

5 years, 7 months ago (2015-05-12 23:53:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:10005) manually as
5de8fbf91cb50eca1ddacf65db2467f830246db0 (presubmit successful).