Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tools/heapcheck/PRESUBMIT.py

Issue 113193008: Remove heapcheck support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | tools/heapcheck/base_unittests.gtest-heapcheck.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/heapcheck/PRESUBMIT.py
diff --git a/tools/heapcheck/PRESUBMIT.py b/tools/heapcheck/PRESUBMIT.py
deleted file mode 100644
index 075dd1c8f4e82ef4b467b8e1b0028ca6122a81bf..0000000000000000000000000000000000000000
--- a/tools/heapcheck/PRESUBMIT.py
+++ /dev/null
@@ -1,63 +0,0 @@
-# Copyright (c) 2011 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""
-See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
-for more details on the presubmit API built into gcl.
-"""
-
-import re
-
-def CheckChange(input_api, output_api):
- """Checks the heapcheck suppressions files for bad data."""
- sup_regex = re.compile('suppressions.*\.txt$')
- suppressions = {}
- errors = []
- check_for_heapcheck = False
- skip_next_line = False
- for f in filter(lambda x: sup_regex.search(x.LocalPath()),
- input_api.AffectedFiles()):
- for line, line_num in zip(f.NewContents(),
- xrange(1, len(f.NewContents()) + 1)):
- line = line.lstrip()
- if line.startswith('#') or not line:
- continue
-
- if skip_next_line:
- if 'insert_a_suppression_name_here' in line:
- errors.append('"insert_a_suppression_name_here" is not a valid '
- 'suppression name')
- if suppressions.has_key(line):
- errors.append('suppression with name "%s" at %s line %s has already '
- 'been defined at line %s' % (line, f.LocalPath(),
- line_num,
- suppressions[line][1]))
- else:
- suppressions[line] = (f, line_num)
- check_for_heapcheck = True
- skip_next_line = False
- continue
- if check_for_heapcheck:
- if not line == 'Heapcheck:Leak':
- errors.append('"%s" should be "Heapcheck:Leak" in %s line %s' %
- (line, f.LocalPath(), line_num))
- check_for_heapcheck = False;
- if line == '{':
- skip_next_line = True
- continue
- if (line.startswith('fun:') or line.startswith('obj:') or
- line == 'Heapcheck:Leak' or line == '}' or
- line == '...'):
- continue
- errors.append('"%s" is probably wrong: %s line %s' % (line, f.LocalPath(),
- line_num))
- if errors:
- return [output_api.PresubmitError('\n'.join(errors))]
- return []
-
-def CheckChangeOnUpload(input_api, output_api):
- return CheckChange(input_api, output_api)
-
-def CheckChangeOnCommit(input_api, output_api):
- return CheckChange(input_api, output_api)
« no previous file with comments | « build/common.gypi ('k') | tools/heapcheck/base_unittests.gtest-heapcheck.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698