Issue 113193005: Use SkFontMgr for webfont construction on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113193005: Use SkFontMgr for webfont construction on windows (Closed)

Created:
7 years ago by eae

Modified:
7 years ago

Reviewers:
pdr., Stephen Chennney

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Use SkFontMgr for webfont construction on windows Change FontCache to expose the SkFontMgr implementation and use that to construct webfonts on windows. This way the appropriate font manager (DirectWrite or GDI) is used for webfonts just as it is for system fonts. BUG=25541 R=schenney@chromium.org,pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163758

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	Source/platform/fonts/FontCache.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/platform/fonts/skia/FontCustomPlatformDataSkia.cpp	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

eae

On 2013/12/12 00:47:12, pdr wrote: > On 2013/12/12 00:35:22, eae wrote: > > This looks ...

7 years ago (2013-12-12 00:53:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/113193005/1

7 years ago (2013-12-12 03:31:37 UTC) #4

Message was sent while issue was closed.

Change committed as 163758