Issue 113193004: remove SkScalarCompare type and header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113193004: remove SkScalarCompare type and header (Closed)

Created:
7 years ago by reed1

Modified:
7 years ago

Reviewers:
f(malita)

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

remove SkScalarCompare type and header BUG= R=fmalita@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=12681

Patch Set 4 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -93 lines)			Patch
M	gyp/core.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/public_headers.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkCanvas.h	View	1 2 3	3 chunks	+12 lines, -14 lines	0 comments	Download
D	include/core/SkScalarCompare.h	View		1 chunk	+0 lines, -38 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	1 2 3	11 chunks	+18 lines, -35 lines	0 comments	Download
M	src/core/SkMatrix.cpp	View		4 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

f(malita)

lgtm https://codereview.chromium.org/113193004/diff/20001/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/113193004/diff/20001/include/core/SkCanvas.h#newcode1106 include/core/SkCanvas.h:1106: const SkRect& getLocalClipBoundsCompareType() const { Maybe rename the ...

7 years ago (2013-12-11 22:30:54 UTC) #2

reed1

https://codereview.chromium.org/113193004/diff/20001/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/113193004/diff/20001/include/core/SkCanvas.h#newcode1106 include/core/SkCanvas.h:1106: const SkRect& getLocalClipBoundsCompareType() const { On 2013/12/11 22:30:54, Florin ...

7 years ago (2013-12-13 21:15:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r12681 (presubmit successful).

Expand Messages | Collapse Messages

Issue 113193004: remove SkScalarCompare type and header (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages