Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1131923005: [RELAND] Fixit: Factor out common base::Time* math operator overloads. (Closed)

Created:
5 years, 7 months ago by miu
Modified:
5 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[RELAND] Fixit: Factor out common base::Time* math operator overloads. This relands https://codereview.chromium.org/1122443004 with a landmine to clobber the iOS builds. This is necessary because Xcode's logic for determining that base/time/time.h changed is faulty and is preventing modules dependent on it from being rebuilt. Revert history: https://codereview.chromium.org/1125283003 BUG=467417, 485435 TBR=stuartmorgan@chromium.org Committed: https://crrev.com/ad576e7a77b87bfd0ed09b46cf9fdfacd342672b Cr-Commit-Position: refs/heads/master@{#329060}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed parens because Python. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -219 lines) Patch
M base/time/time.h View 17 chunks +158 lines, -206 lines 0 comments Download
M base/time/time.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M base/time/time_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M build/get_landmines.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
miu
stuartmorgan and thakis: PTAL at build/get_landmines.py. History on why the landmine is needed (to clobber ...
5 years, 7 months ago (2015-05-08 20:49:47 UTC) #2
Lei Zhang
base/ lgtm since it's unchanged.
5 years, 7 months ago (2015-05-08 20:51:50 UTC) #3
Nico
lgtm https://codereview.chromium.org/1131923005/diff/1/build/get_landmines.py File build/get_landmines.py (right): https://codereview.chromium.org/1131923005/diff/1/build/get_landmines.py#newcode72 build/get_landmines.py:72: if (platform() == 'ios'): remove parens
5 years, 7 months ago (2015-05-08 20:55:41 UTC) #4
miu
https://codereview.chromium.org/1131923005/diff/1/build/get_landmines.py File build/get_landmines.py (right): https://codereview.chromium.org/1131923005/diff/1/build/get_landmines.py#newcode72 build/get_landmines.py:72: if (platform() == 'ios'): On 2015/05/08 20:55:41, Nico wrote: ...
5 years, 7 months ago (2015-05-08 21:09:40 UTC) #5
miu
Re-reading the discussion in the bug, it looks like the problem is pretty well understood. ...
5 years, 7 months ago (2015-05-09 01:47:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131923005/20001
5 years, 7 months ago (2015-05-09 01:48:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 06:04:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131923005/20001
5 years, 7 months ago (2015-05-09 09:36:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 13:41:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131923005/20001
5 years, 7 months ago (2015-05-09 18:59:23 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-10 00:15:31 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-10 00:16:36 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad576e7a77b87bfd0ed09b46cf9fdfacd342672b
Cr-Commit-Position: refs/heads/master@{#329060}

Powered by Google App Engine
This is Rietveld 408576698