Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: public/platform/modules/presentation/WebPresentationClient.h

Issue 1131913002: [PresentationAPI] Make WebPresentationClient.sendString and sendArrayBuffer methods pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/modules/presentation/WebPresentationClient.h
diff --git a/public/platform/modules/presentation/WebPresentationClient.h b/public/platform/modules/presentation/WebPresentationClient.h
index a5a7f229820a7cf5e042641bf29bec8833347436..15e4d6e15845395d0046f36c3c35d3e8381763bf 100644
--- a/public/platform/modules/presentation/WebPresentationClient.h
+++ b/public/platform/modules/presentation/WebPresentationClient.h
@@ -40,17 +40,11 @@ public:
// The ownership of the |callbacks| argument is transferred to the embedder.
virtual void joinSession(const WebString& presentationUrl, const WebString& presentationId, WebPresentationSessionClientCallbacks*) = 0;
- // TODO(s.singapati): Make below send methods pure virtual once Chromium has the implementation.
// Called when the frame requests to send String message to an existing session.
- virtual void sendString(const WebString& presentationUrl, const WebString& presentationId, const WebString& message)
- {
- BLINK_ASSERT_NOT_REACHED();
- }
+ virtual void sendString(const WebString& presentationUrl, const WebString& presentationId, const WebString& message) = 0;
+
// Called when the frame requests to send ArrayBuffer/View data to an existing session.
- virtual void sendArrayBuffer(const WebString& presentationUrl, const WebString& presentationId, const uint8_t* data, size_t length)
- {
- BLINK_ASSERT_NOT_REACHED();
- }
+ virtual void sendArrayBuffer(const WebString& presentationUrl, const WebString& presentationId, const uint8_t* data, size_t length) = 0;
// Called when the frame requests to close an existing session.
virtual void closeSession(const WebString& url, const WebString& presentationId) = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698