Issue 1131913002: [PresentationAPI] Make WebPresentationClient.sendString and sendArrayBuffer methods pure virtual.

Issue 1131913002: [PresentationAPI] Make WebPresentationClient.sendString and sendArrayBuffer methods pure virtual. (Closed)

Created:
5 years, 7 months ago by USE s.singapati at gmail.com

Modified:
5 years, 7 months ago

Reviewers:
mark a. foltz, whywhat

CC:
blink-reviews, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

[PresentationAPI] Make WebPresentationClient.sendString and sendArrayBuffer methods pure virtual. This has to be submitted only after the Chromium change lands. Blink CL: https://codereview.chromium.org/1002293005/ Chromium CL: https://codereview.chromium.org/1037483003/ BUG=459008 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195242

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	public/platform/modules/presentation/WebPresentationClient.h	View		1 chunk	+3 lines, -9 lines	0 comments	Download

Total messages: 8 (2 generated)

whywhat

lgtm please mention in the change description that this has to be submitted only after ...

5 years, 7 months ago (2015-05-07 14:24:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131913002/1

5 years, 7 months ago (2015-05-12 10:35:07 UTC) #7

commit-bot: I haz the power

5 years, 7 months ago (2015-05-12 11:55:35 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195242