base/android/java/src/org/chromium/base/README_logging.md - Issue 1131903007: [Android log] Promote using hardcoded string tags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/java/src/org/chromium/base/README_logging.md

Issue 1131903007: [Android log] Promote using hardcoded string tags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add length check and test, remove java tag check Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/android/java/src/org/chromium/base/README_logging.md

diff --git a/base/android/java/src/org/chromium/base/README_logging.md b/base/android/java/src/org/chromium/base/README_logging.md

index 21938264736ef436f4ed9145cf301880c4a2047c..044326f112629b974039431abe77d4793eb9602b 100644

--- a/base/android/java/src/org/chromium/base/README_logging.md

+++ b/base/android/java/src/org/chromium/base/README_logging.md

@@ -9,7 +9,7 @@ or off for individual groups.

Usage:

- private static final String TAG = Log.makeTag("Tag");

+ private static final String TAG = "cr.Tag";

...

Log.i(TAG, "Some debug info: %s", data);

« PRESUBMIT.py ('K') | « base/android/java/src/org/chromium/base/Log.java ('k') | no next file » | no next file with comments »