[Android log] Promote using hardcoded string tags

[Android log] Promote using hardcoded string tags

This is to avoid static initializers that would make the code slower.
See the linked bug for discussion.

This patch deprecates Log#makeTag(String) and adds presubmit checks
to enforce at submit time what makeTag was trying to do: length and
naming rules

BUG=485772
Committed: https://crrev.com/aa68d5ec85d3d708557fe8004e6e6ad04416cd0d
Cr-Commit-Position: refs/heads/master@{#333710}

[dgn, 2015-05-18 17:56:11]

dgn@chromium.org changed reviewers:
+ dfalcantara@chromium.org, jochen@chromium.org, yfriedman@chromium.org

[dgn, 2015-05-18 17:56:12]

PTAL. According to the discussion on the bug, I added presubmit checks to notify
for correct log usage rather than doing those checks in the code. So I used
regexes (http://xkcd.com/1171/) to try to detect stuff that I want to warn
about. The only non skippable error is the one about the tag length, because it
causes runtime exception

jochen@: please review changes in PRESUBMIT*
yfriedman@: please review changes in Log.java and README_logging.md
dfalcantara@: FYI

https://codereview.chromium.org/1131903007/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1131903007/diff/40001/PRESUBMIT.py#newcode1374
PRESUBMIT.py:1374: def _CheckNoNewUtilLogUsage(input_api, output_api):
Did not touch at this one because downstream uses it.

[Yaron, 2015-05-20 13:51:48]

On 2015/05/18 17:56:12, dgn wrote:
> PTAL. According to the discussion on the bug, I added presubmit checks to
notify
> for correct log usage rather than doing those checks in the code. So I used
> regexes (http://xkcd.com/1171/) to try to detect stuff that I want to warn
> about. The only non skippable error is the one about the tag length, because
it
> causes runtime exception
> 
> jochen@: please review changes in PRESUBMIT*
> yfriedman@: please review changes in Log.java and README_logging.md

Those 2 lgtm

> dfalcantara@: FYI
> 
> https://codereview.chromium.org/1131903007/diff/40001/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> https://codereview.chromium.org/1131903007/diff/40001/PRESUBMIT.py#newcode1374
> PRESUBMIT.py:1374: def _CheckNoNewUtilLogUsage(input_api, output_api):
> Did not touch at this one because downstream uses it.

[dgn, 2015-06-09 13:37:11]

jochen@ can you PTAL at PRESUBMIT.py and PRESUBMIT_test.py?

After the rebase, they now run only at upload time and will not affect
committing bots.

[jochen (gone - plz use gerrit), 2015-06-10 08:33:45]

lgtm

[dgn, 2015-06-10 08:56:11]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[dgn, 2015-06-10 08:56:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1131903007/#ps60001
(title: "Rebased, renamed the android group check")

[commit-bot: I haz the power, 2015-06-10 08:56:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131903007/60001

[commit-bot: I haz the power, 2015-06-10 10:01:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-10 10:01:38]

Dry run: This issue passed the CQ dry run.

[dgn, 2015-06-10 10:04:21]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2015-06-10 10:04:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131903007/60001

[commit-bot: I haz the power, 2015-06-10 10:08:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-10 10:09:27]

Patchset 4 (id:??) landed as
https://crrev.com/aa68d5ec85d3d708557fe8004e6e6ad04416cd0d
Cr-Commit-Position: refs/heads/master@{#333710}