Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1131903002: Revert of Make V8 extras a separate type of native (Closed)

Created:
5 years, 7 months ago by domenic
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Make V8 extras a separate type of native (patchset #4 id:60001 of https://codereview.chromium.org/1129743003/) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2745 Original issue's description: > Make V8 extras a separate type of native > > Instead of making them an extra option that gets passed in and compiled > at the end of the natives file for a given run of js2c, we now make them a > separate run of js2c with a separate natives file output. > > This natives file output is then compiled in the bootstrapper. It is not part > of the snapshot (yet), but instead is treated similar to the experimental > natives, just without any of the complexity that comes from tieing the > behavior to flags. We also don't add counterparts to > InitializeExperimentalGlobal and InstallExperimentalNativeFunctions, yet. > > R=yangguo@chromium.org, jochen@chromium.org > BUG= > > Committed: https://crrev.com/c93aff4ac63ad9ffb6318e750335208de32b7902 > Cr-Commit-Position: refs/heads/master@{#28296} TBR=jochen@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/010c515d0fb78e06803cb0293aefe58f755ef646 Cr-Commit-Position: refs/heads/master@{#28299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -136 lines) Patch
M BUILD.gn View 6 chunks +0 lines, -37 lines 0 comments Download
M src/bootstrapper.cc View 8 chunks +3 lines, -32 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/snapshot/natives.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/snapshot/natives-external.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 7 chunks +5 lines, -31 lines 0 comments Download
M tools/js2c.py View 8 chunks +30 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
domenic
Created Revert of Make V8 extras a separate type of native
5 years, 7 months ago (2015-05-07 14:09:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131903002/1
5 years, 7 months ago (2015-05-07 14:09:38 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-07 14:09:40 UTC) #4
Michael Achenbach
lgtm
5 years, 7 months ago (2015-05-07 14:26:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131903002/1
5 years, 7 months ago (2015-05-07 14:26:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 14:26:44 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 14:27:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/010c515d0fb78e06803cb0293aefe58f755ef646
Cr-Commit-Position: refs/heads/master@{#28299}

Powered by Google App Engine
This is Rietveld 408576698