Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1131853007: Revert of Revert of Disable blink_perf.canvas on linux. (Closed)

Created:
5 years, 7 months ago by Sami
Modified:
5 years, 7 months ago
Reviewers:
sullivan, shatch
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Disable blink_perf.canvas on linux. (patchset #1 id:1 of https://codereview.chromium.org/1142643002/) Reason for revert: Looks like this is still failing consistently :( http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(4) Original issue's description: > Revert of Disable blink_perf.canvas on linux. (patchset #1 id:1 of https://codereview.chromium.org/1129383007/) > > Reason for revert: > Possible fix has landed, reverting to see if bot goes green. > > Original issue's description: > > Disable blink_perf.canvas on linux. > > > > This has been red going on a week now. > > > > BUG=488059 > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > > > Committed: https://crrev.com/2e2d7141b8f141bfb194427afde9fb2bf1ed5486 > > Cr-Commit-Position: refs/heads/master@{#330085} > > TBR=sullivan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=488059 > > Committed: https://crrev.com/c67128f7fb96c1e40bfb46a9ba7a1466a754f357 > Cr-Commit-Position: refs/heads/master@{#330086} TBR=sullivan@chromium.org,simonhatch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488059 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sami
Created Revert of Revert of Disable blink_perf.canvas on linux.
5 years, 7 months ago (2015-05-15 17:45:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131853007/1
5 years, 7 months ago (2015-05-15 17:46:17 UTC) #2
commit-bot: I haz the power
Commit queue failed due to new patchset.
5 years, 7 months ago (2015-05-15 17:50:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131853007/40001
5 years, 7 months ago (2015-05-15 17:50:30 UTC) #6
commit-bot: I haz the power
Failed to apply patch for tools/perf/benchmarks/blink_perf.py: While running git apply --index -3 -p1; error: patch ...
5 years, 7 months ago (2015-05-15 17:53:16 UTC) #8
sullivan
5 years, 7 months ago (2015-05-15 20:32:39 UTC) #10
lgtm

Powered by Google App Engine
This is Rietveld 408576698