Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: remoting/webapp/app_remoting/js/feedback_consent.js

Issue 1131853004: Include the session id in feedback logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed blank line. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/app_remoting/js/feedback_consent.js
diff --git a/remoting/webapp/app_remoting/js/feedback_consent.js b/remoting/webapp/app_remoting/js/feedback_consent.js
index ef9a0ec218bab714cbda3928bdd2ce514d198152..7d815218e14d20cbec98632a599401a4ad7f5b3e 100644
--- a/remoting/webapp/app_remoting/js/feedback_consent.js
+++ b/remoting/webapp/app_remoting/js/feedback_consent.js
@@ -18,6 +18,12 @@ var hostId = '@pending';
var connectionStats = '';
/**
+ * @type {string} The most recent id for the session (unless the session is
+ * longer than 24hrs, this will be the only session id).
+ */
+var sessionId = '';
+
+/**
* @type {string} "no" => user did not request a VM reset; "yes" => VM was
* successfully reset; "failed" => user requested a reset, but it failed.
*/
@@ -66,7 +72,8 @@ function onUserInfo(email, realName) {
'&psd_abandonHost=' + escape(abandonHost) +
'&psd_crashServiceReportId=' + escape(crashServiceReportId) +
'&psd_connectionStats=' + escape(connectionStats) +
- '&psd_category=' + escape(selectedCategory));
+ '&psd_category=' + escape(selectedCategory) +
+ '&psd_sessionId=' + escape(sessionId));
window.close();
// If the VM was successfully abandoned, close the application.
@@ -242,6 +249,7 @@ function onWindowMessage(event) {
hostId = /** @type {string} */ (event.data['hostId']);
}
connectionStats = /** @type {string} */ (event.data['connectionStats']);
+ sessionId = /** @type {string} */ (event.data['sessionId']);
}
};
« no previous file with comments | « remoting/webapp/app_remoting/js/application_context_menu.js ('k') | remoting/webapp/base/js/client_session.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698