Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: remoting/webapp/app_remoting/js/application_context_menu.js

Issue 1131853004: Include the session id in feedback logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer feedback. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/app_remoting/js/application_context_menu.js
diff --git a/remoting/webapp/app_remoting/js/application_context_menu.js b/remoting/webapp/app_remoting/js/application_context_menu.js
index ae1b4b0923a140b0046070ed2f318f02f395a60c..6e07a1fc29945657df856a7a858689a6b2206ad6 100644
--- a/remoting/webapp/app_remoting/js/application_context_menu.js
+++ b/remoting/webapp/app_remoting/js/application_context_menu.js
@@ -15,13 +15,18 @@ var remoting = remoting || {};
/**
* @param {remoting.ContextMenuAdapter} adapter
* @param {remoting.ClientPlugin} plugin
+ * @param {remoting.ClientSession} clientSession
+ *
* @constructor
* @implements {base.Disposable}
*/
-remoting.ApplicationContextMenu = function(adapter, plugin) {
- /** @private {remoting.ContextMenuAdapter} */
+remoting.ApplicationContextMenu = function(adapter, plugin, clientSession) {
+ /** @private */
this.adapter_ = adapter;
+ /** @private */
+ this.clientSession_ = clientSession;
+
this.adapter_.create(
remoting.ApplicationContextMenu.kSendFeedbackId,
l10n.getTranslationOrError(/*i18n-content*/'SEND_FEEDBACK'),
@@ -94,7 +99,8 @@ remoting.ApplicationContextMenu.prototype.onClicked_ = function(info) {
var message = {
method: 'init',
hostId: that.hostId_,
- connectionStats: JSON.stringify(that.stats_.mostRecent())
+ connectionStats: JSON.stringify(that.stats_.mostRecent()),
+ sessionId: that.clientSession_.getLogSessionId()
kelvinp 2015/05/14 01:18:05 that.clientSession_.logger().getSessionId();
Jamie 2015/05/14 01:38:07 ClientSession does not have a logger() method. Are
kelvinp 2015/05/14 01:44:45 My bad, s/logger()/getLogger()
Jamie 2015/05/14 16:39:39 My checkout wasn't up-to-date. Done.
};
consentWindow.contentWindow.postMessage(message, '*');
};
« no previous file with comments | « remoting/webapp/app_remoting/js/app_connected_view.js ('k') | remoting/webapp/app_remoting/js/feedback_consent.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698