Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: remoting/webapp/base/js/client_session.js

Issue 1131853004: Include the session id in feedback logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/base/js/client_session.js
diff --git a/remoting/webapp/base/js/client_session.js b/remoting/webapp/base/js/client_session.js
index db13e65fa54a9ad382909f79cfab4103d5de8436..020ce349add9208f71fa0f7c7419f62437b2db29 100644
--- a/remoting/webapp/base/js/client_session.js
+++ b/remoting/webapp/base/js/client_session.js
@@ -329,6 +329,14 @@ remoting.ClientSession.prototype.getError = function() {
};
/**
+ * @return {string} The current session id. This is random GUID, refreshed
+ * every 24hrs.
+ */
+remoting.ClientSession.prototype.getSessionId = function() {
+ return this.logToServer_.getSessionId();
kelvinp 2015/05/13 22:36:53 use this.sessionId_ instead.
Jamie 2015/05/13 23:41:24 I hadn't realized there was already a sessionId_ m
kelvinp 2015/05/14 01:18:04 On I see, in this, case, you can access the logger
+};
+
+/**
* Called when the client receives its first frame.
*
* @return {void} Nothing.
@@ -604,4 +612,3 @@ remoting.ClientSession.prototype.reportStatistics = function() {
remoting.ClientSession.prototype.logHostOfflineErrors = function(enable) {
this.logHostOfflineErrors_ = enable;
};
-

Powered by Google App Engine
This is Rietveld 408576698